Feat/pyinstaller ci #221
Merged
Feat/pyinstaller ci #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # electron/install.js # package.json # pyproject.toml
# Conflicts: # electron/install.js
…ontractInfo provider
Staking Info interval, general refactor for DX and performance
truemiller
approved these changes
Jul 10, 2024
0xArdi
commented
Jul 10, 2024
| @@ -3,6 +3,7 @@ description: "A single-agent service (sovereign agent) placing bets on Omen" | |||
| hash: bafybeihrogxx2kgl7euvhqsbh33fi4tzuupxodoheraqxd6lkvtvljewtu | |||
| image: https://operate.olas.network/_next/image?url=%2Fimages%2Fprediction-agent.png&w=3840&q=75 | |||
| configuration: | |||
| trader_version: v0.16.4 | |||
There was a problem hiding this comment.
This needs to be updated when a new version of trader is meant to be used.
There was a problem hiding this comment.
We reference it by the hash (which is what is fetched ultimately). What impact does this version have?
There was a problem hiding this comment.
In particular, we have a recent hash update #225 , but there is no release of the trader repository yet. What happens in this situation? Can we use the hash still?
There was a problem hiding this comment.
@jmoreira-valory this specifies the aea binary that needs to be used when running the agent. It may be that deps change.
|
@0xArdi please make sure trader.yaml is consistent with the .ts file as well, as discussed. |
|
@jmoreira-valory its addressed |
jmoreira-valory
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for building pearl binary in CI.