Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export Agent Logs & Better logging #218

Merged
merged 20 commits into from
Jul 6, 2024
Merged

Export Agent Logs & Better logging #218

merged 20 commits into from
Jul 6, 2024

Conversation

truemiller
Copy link
Collaborator

@truemiller truemiller commented Jul 4, 2024 •
edited
Loading

  • Included agent logs from service directories
  • Split logging by application (CLI, Next, Electron)
  • Clearly defined in terminal
  • Separate files are written to .operate for each application
  • Max file size is 10mb before rotation of each file above
  • Moved paths to constants/paths.js from install.js
  • Removed unused brew script
  • Refactored "export logs as zip" logic

Console log
image

CLI log file
image

Next log file
image

Electron log file (no errors thus far)
image

Exporting
image

Zip file
image

@truemiller truemiller marked this pull request as draft July 5, 2024 09:24
@truemiller truemiller marked this pull request as ready for review July 5, 2024 12:15
truemiller
truemiller commented Jul 5, 2024
View reviewed changes
electron/logger.js Outdated Show resolved Hide resolved
truemiller
truemiller commented Jul 5, 2024
View reviewed changes
electron/scripts.js Outdated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no longer used

@truemiller truemiller changed the title Better logging Export Agent Logs & Better logging Jul 5, 2024
@truemiller truemiller mentioned this pull request Jul 5, 2024
Closed
0xArdi
0xArdi approved these changes Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@0xArdi 0xArdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@truemiller
Extend santization regex to support Linux and Mac.
a31a368 
Add version and date ISO string to export zip.
@truemiller truemiller merged commit 19c6b21 into main Jul 6, 2024
4 checks passed
@truemiller truemiller deleted the feat/better-logging branch July 26, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oaksprout oaksprout oaksprout approved these changes

@0xArdi 0xArdi 0xArdi approved these changes

@mohandast52 mohandast52 mohandast52 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@truemiller @mohandast52 @0xArdi @oaksprout