Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: addressing C4R issues 56 and 27 #166

Merged
merged 21 commits into from
Jul 12, 2024

Conversation

kupermind
Copy link
Collaborator

  • Addressing C4R issues 56 and 27.

@kupermind kupermind requested review from DavidMinarsch and 77ph July 4, 2024 19:16
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (addressing_issue_37@9a6cda5). Learn more about missing BASE report.

Files Patch % Lines
contracts/Dispenser.sol 60.00% 2 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##             addressing_issue_37     #166   +/-   ##
======================================================
  Coverage                       ?   97.14%           
======================================================
  Files                          ?       22           
  Lines                          ?     1718           
  Branches                       ?      386           
======================================================
  Hits                           ?     1669           
  Misses                         ?       49           
  Partials                       ?        0           
Flag Coverage Δ
unittests 97.14% <60.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kupermind kupermind merged commit 9f29a7b into addressing_issue_37 Jul 12, 2024
2 checks passed
@kupermind kupermind deleted the addressing_issues_56_27 branch July 12, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants