Skip to content

refactor: addressing interim internal audit findings #829

refactor: addressing interim internal audit findings

refactor: addressing interim internal audit findings #829

Triggered via pull request August 1, 2024 10:00
@kupermindkupermind
synchronize #182
aip1_3
Status Failure
Total duration 4m 25s
Artifacts

workflow.yaml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 23 warnings
gitleaks
Process completed with exit code 1.
build
Process completed with exit code 1.
gitleaks
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
build
The following actions uses node12 which is deprecated and will be forced to run on node16: codecov/codecov-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, codecov/codecov-action@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
build: contracts/interfaces/IUniswapV2Pair.sol#L6
Rule is set with explicit type [var/s: uint]
build: contracts/BondCalculator.sol#L2
Found more than One contract per file. 2 contracts found!
build: contracts/BondCalculator.sol#L6
global import of path ./interfaces/IUniswapV2Pair.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
build: contracts/BondCalculator.sol#L74
Immutable variables name are set to be in capitalized SNAKE_CASE
build: contracts/BondCalculator.sol#L76
Immutable variables name are set to be in capitalized SNAKE_CASE
build: contracts/BondCalculator.sol#L78
Immutable variables name are set to be in capitalized SNAKE_CASE
build: contracts/Depository.sol#L2
Found more than One contract per file. 2 contracts found!
build: contracts/Depository.sol#L124
Immutable variables name are set to be in capitalized SNAKE_CASE
build: contracts/Dispenser.sol#L2
Found more than One contract per file. 6 contracts found!
build: contracts/Dispenser.sol#L280
Immutable variables name are set to be in capitalized SNAKE_CASE
build: deploy/contracts.js#L3
'expect' is assigned a value but never used
build: deploy/contracts.js#L7
'deployer' is assigned a value but never used
build: scripts/deployment/staking/arbitrum/bridge_new_token.js#L4
'L1ERC20Gateway' is assigned a value but never used
build: scripts/deployment/staking/arbitrum/bridge_new_token.js#L5
'L2ERC20Gateway' is assigned a value but never used
build: scripts/deployment/staking/arbitrum/bridge_new_token.js#L6
'L1ToL2MessageGasEstimator' is assigned a value but never used
build: scripts/deployment/staking/arbitrum/bridge_new_token.js#L8
'getBaseFee' is assigned a value but never used
build: scripts/deployment/staking/arbitrum/send_tokens_and_message.js#L40
'ethBridger' is assigned a value but never used
build: scripts/deployment/staking/gnosis/send_tokens_and_message.js#L19
'l2TargetDispenserAddress' is assigned a value but never used
build: scripts/deployment/staking/gnosis/send_tokens_and_message.js#L41
'bridgePayload' is assigned a value but never used
build: scripts/deployment/staking/optimistic/send_tokens_and_message.js#L19
'l2TargetDispenserAddress' is assigned a value but never used