Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tokens): update price history endpoint #6367

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

bakoushin
Copy link
Contributor

Description

Fetch price history from the new https://api.mainnet.valora.xyz/getTokenPriceHistory enpdoint instead of the blockchain-api.

Test plan

  • Tested manually
  • Updated unit test

Related issues

Backwards compatibility

Y

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.02%. Comparing base (bef3560) to head (cfe2bfc).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6367      +/-   ##
==========================================
- Coverage   89.02%   89.02%   -0.01%     
==========================================
  Files         735      735              
  Lines       31325    31327       +2     
  Branches     5506     5809     +303     
==========================================
+ Hits        27887    27888       +1     
+ Misses       3393     3246     -147     
- Partials       45      193     +148     
Files with missing lines Coverage Δ
src/priceHistory/saga.ts 90.00% <100.00%> (ø)
src/web3/networkConfig.ts 100.00% <100.00%> (ø)

... and 66 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bef3560...cfe2bfc. Read the comment docs.

Copy link
Collaborator

@kathaypacific kathaypacific left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@bakoushin bakoushin added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit c6e2357 Dec 16, 2024
15 checks passed
@bakoushin bakoushin deleted the alex/token-price-history-endpoint branch December 16, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants