fix(earn): Show correct fiat and token amount on earn collect screen #6130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6130 +/- ##
========================================
Coverage 88.75% 88.75%
========================================
Files 727 727
Lines 30804 30806 +2
Branches 5629 5630 +1
========================================
+ Hits 27341 27343 +2
- Misses 3264 3419 +155
+ Partials 199 44 -155
... and 66 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
MuckT
approved these changes
Oct 3, 2024
satish-ravi
approved these changes
Oct 3, 2024
jeanregisser
pushed a commit
that referenced
this pull request
Oct 4, 2024
…6130) ### Description withdrawToken is not 1:1 with depositToken, need to convert withdrawToken balance to depositToken using pricePerShare ### Test plan Without change (mismatch): https://github.com/user-attachments/assets/160417bf-9047-4a63-ae16-5568c08a6861 With change (no mismatch): https://github.com/user-attachments/assets/f4e01cd0-9005-4c99-a9b8-2a4d7e013fad ### Related issues - Fixes N/A ### Backwards compatibility Yes ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [X] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
bakoushin
pushed a commit
that referenced
this pull request
Oct 17, 2024
…6130) ### Description withdrawToken is not 1:1 with depositToken, need to convert withdrawToken balance to depositToken using pricePerShare ### Test plan Without change (mismatch): https://github.com/user-attachments/assets/160417bf-9047-4a63-ae16-5568c08a6861 With change (no mismatch): https://github.com/user-attachments/assets/f4e01cd0-9005-4c99-a9b8-2a4d7e013fad ### Related issues - Fixes N/A ### Backwards compatibility Yes ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [X] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
withdrawToken is not 1:1 with depositToken, need to convert withdrawToken balance to depositToken using pricePerShare
Test plan
Without change (mismatch):
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-10-03.at.13.06.53.mp4
With change (no mismatch):
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-10-03.at.13.06.29.mp4
Related issues
Backwards compatibility
Yes
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: