feat(CAB): Add landing screen for phone verification (recovery) #4821
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4821 +/- ##
==========================================
+ Coverage 85.37% 85.40% +0.02%
==========================================
Files 728 729 +1
Lines 29522 29562 +40
Branches 5172 5175 +3
==========================================
+ Hits 25203 25246 +43
+ Misses 4073 4070 -3
Partials 246 246
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| style={{ | ||
| padding: Spacing.Thick24, | ||
| alignItems: 'center', | ||
| }} |
There was a problem hiding this comment.
nit: assign this style a variable name and put it with the others
| size={BtnSizes.FULL} | ||
| testID="LinkPhoneNumberButton" | ||
| /> | ||
| <TextButton |
There was a problem hiding this comment.
Looking at the designs here, it looks like this secondary button is styled differently. (Also the primary button is a different shade of green.) I see that this PR follows the designs shown in the Figma preview in the Linear ticket - should the designs in Figma be the source of truth here? (or am I looking at the wrong designs in Figma?)
|
|
||
| useLayoutEffect(() => { | ||
| navigation.setOptions({ | ||
| headerLeft: () => <BackButton />, |
There was a problem hiding this comment.
From the image you posted, it looks like the header background is a different color than the page background, which doesn't match the designs.
| <Button | ||
| text={t('linkPhoneNumber.startButtonLabel')} | ||
| onPress={() => navigate(Screens.VerificationStartScreen, { hideOnboardingStep: true })} | ||
| style={{ marginBottom: Spacing.Thick24, width: '100%' }} |
There was a problem hiding this comment.
nit: bring styles out into style object
| <TextButton | ||
| testID="LinkPhoneNumberLater" | ||
| style={{ color: colors.primary }} | ||
| onPress={() => navigateHome()} |
There was a problem hiding this comment.
Can you add an analytics event for both buttons?
…ra-inc#4821) ### Description Add in link phone number landing screen. This will come after successfully completing the recovery flow. Not hooked up yet since [that work](https://linear.app/valora/issue/ACT-781/recovery-success-screen) isn't done. ### Test plan Unit tests added. https://github.com/valora-inc/wallet/assets/140328381/1f1e14ca-bbb6-4453-871e-d85769b4f141 ### Related issues - Fixes #[ACT-768] ### Backwards compatibility Yes, just adding new screen.
Description
Add in link phone number landing screen. This will come after successfully completing the recovery flow. Not hooked up yet since that work isn't done.
Test plan
Unit tests added.
landing_screen.mp4
Related issues
Backwards compatibility
Yes, just adding new screen.