-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update fiat exchange flow to use token IDs #4450
Merged
finnian0826
merged 52 commits into
main
from
finnian0826/use-token-ids-in-fiat-exchange-flow
Dec 2, 2023
Merged
Changes from all commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
240a141
initial work on removing cicocurrency enum
finnian0826 7f46333
continue token id update
finnian0826 2a30eae
more clean up
finnian0826 e3e8bc3
Merge branch 'main' into finnian0826/use-token-ids-in-fiat-exchange-flow
finnian0826 f098bd9
even more
finnian0826 3a5fd94
Merge branch 'main' into finnian0826/use-token-ids-in-fiat-exchange-flow
finnian0826 8033f95
update quotes
finnian0826 c366b31
fix type errors
finnian0826 4d164a9
fix tests
finnian0826 5c90df3
fix some hook issues
finnian0826 efa21f5
fix tests
finnian0826 1e8afbd
Merge branch 'main' into finnian0826/use-token-ids-in-fiat-exchange-flow
finnian0826 e9dba4b
fix saga hooks (hopefully)
finnian0826 c2fc19b
fix FiatExchangeAmount hook call
finnian0826 f08b467
fix tests
finnian0826 f69e32d
clean up
finnian0826 0166cba
fix add flow header
finnian0826 6b2426b
feedback
finnian0826 3905489
fix tests
finnian0826 f8b8592
fix hardcoded token symbols
finnian0826 278c14d
Merge branch 'main' into finnian0826/use-token-ids-in-fiat-exchange-flow
finnian0826 b365381
clean up
finnian0826 2083582
self review
finnian0826 6ff0101
remove eth check
finnian0826 97d3afe
Merge branch 'main' into finnian0826/use-token-ids-in-fiat-exchange-flow
finnian0826 72d40ea
feedback
finnian0826 332f23c
Merge branch 'main' into finnian0826/use-token-ids-in-fiat-exchange-flow
finnian0826 0614266
fix merge
finnian0826 2da137b
clean up
finnian0826 d7a9429
Merge branch 'main' into finnian0826/use-token-ids-in-fiat-exchange-flow
finnian0826 9dd6bbb
refactor
finnian0826 5e22cf2
clean up
finnian0826 b7ac5fa
Merge branch 'main' into finnian0826/use-token-ids-in-fiat-exchange-flow
finnian0826 b8ee42b
fix merge
finnian0826 32bee1a
Merge branch 'main' into finnian0826/use-token-ids-in-fiat-exchange-flow
finnian0826 2e2d1f6
Merge branch 'main' into finnian0826/use-token-ids-in-fiat-exchange-flow
finnian0826 dc89201
fix merge imports
finnian0826 23cd8e3
feedback
finnian0826 cd0d41b
fix test
finnian0826 90d504c
more clean up
finnian0826 f28024e
update stuff
finnian0826 ef48fe4
feedback
finnian0826 9e1bced
Merge branch 'main' into finnian0826/use-token-ids-in-fiat-exchange-flow
finnian0826 2e4a10b
fix navigation for new bottom sheet
finnian0826 bc5ffaf
feedback
finnian0826 41b3567
fix cico logic and fix tests
finnian0826 83938d3
fix test
finnian0826 b1c2f26
add regression testing
finnian0826 39818cd
Merge branch 'main' into finnian0826/use-token-ids-in-fiat-exchange-flow
cajubelt 73727cf
Merge branch 'main' into finnian0826/use-token-ids-in-fiat-exchange-flow
cajubelt bd88cb4
Merge branch 'main' into finnian0826/use-token-ids-in-fiat-exchange-flow
cajubelt 75c5c5d
Merge branch 'main' into finnian0826/use-token-ids-in-fiat-exchange-flow
finnian0826 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is being changed from
AnalyticsCurrency
to string to allow any token symbol to be passed here. In the future, this allows for adding new CICO currencies without wallet changes.