fix(fees): set tip on Celo from eth_maxPriorityFeePerGas

[jeanregisser]

Description

We initially got the recommendation to only set maxFeePerGas to the result of eth_gasPrice and that the difference between it and the base fee would be the tip distributed to the validator.

However after testing, we noticed that if we leave maxPriorityFeePerGas to undefined (or if we don't specify it), the final serialized tx has is set to 0.
Resulting to 0 tip being effectively distributed to the validator. Which doesn't look right for validators 😄

So here we bring back the original implementation I was originally proposing where we set it to the result of eth_maxPriorityFeePerGas. Similar to what viem does on Ethereum.

Note: we'll wait for the confirmation from cLabs before merging this though.

Test plan

• Updated tests

Related issues

• N/A

Backwards compatibility

Yes

[codecov]

Codecov Report

Merging #4444 (ed14032) into main (b06f1e3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #4444   +/-   ##
=======================================
  Coverage   85.09%   85.09%           
=======================================
  Files         711      711           
  Lines       26380    26386    +6     
  Branches     3573     3574    +1     
=======================================
+ Hits        22448    22454    +6     
  Misses       3869     3869           
  Partials       63       63           

Files	Coverage Δ
src/viem/estimateFeesPerGas.ts	100.00% <100.00%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b06f1e3...ed14032. Read the comment docs.

[bakoushin]

💯