fix(viem): Adding standby tx after sending

[dievazqu]

Description

Adding the standby transaction only after the transaction has been sent to the blockchain in the viem flow.

Test plan

Run locally in a emulator and unit tests

Related issues

• Fixes RET-896

Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2023-11-14.at.05.49.05.mp4

[codecov]

Codecov Report

Merging #4443 (a5a6fed) into main (cab4bcd) will decrease coverage by 0.02%.
The diff coverage is 73.68%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4443      +/-   ##
==========================================
- Coverage   85.20%   85.19%   -0.02%     
==========================================
  Files         712      712              
  Lines       26587    26596       +9     
  Branches     3624     3627       +3     
==========================================
+ Hits        22653    22658       +5     
- Misses       3871     3875       +4     
  Partials       63       63              

Files	Coverage Δ
src/viem/saga.ts	94.89% <100.00%> (+0.95%)	⬆️
src/transactions/reducer.ts	56.94% <0.00%> (-3.35%)	⬇️

... and 1 file with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cab4bcd...a5a6fed. Read the comment docs.

[kathaypacific]

this seems good to me, would be good to get @jeanregisser 's eyes on this too. last time i missed some details in #4395 🙈

[jeanregisser]

Thanks!

I'm slightly confused by the example video because it shows the swap flow, but right now it doesn't use src/viem/saga.ts, which was changed in this PR.

Did I miss something?

[jeanregisser]

In theory the addStandbyTransaction action could be called mutliple times, because it's wrapped in

wallet/src/transactions/send.ts

Line 272 in ec4623e

for (let i = 1; i <= TX_NUM_TRIES; i++) {

However, right now this TX_NUM_TRIES is set to 1.

I think just to be safe, we should update the reducer to replace any standby TX which has the same hash or context id.

wallet/src/transactions/reducer.ts

Lines 72 to 83 in b99b375

	case Actions.ADD_STANDBY_TRANSACTION:
	return {
	...state,
	standbyTransactions: [
	{
	...action.transaction,
	timestamp: Date.now(),
	status: TransactionStatus.Pending,
	},
	...(state.standbyTransactions || []),
	],
	}

What do you think?

[dievazqu]

Sounds good!

[dievazqu]

Thanks!

I'm slightly confused by the example video because it shows the swap flow, but right now it doesn't use src/viem/saga.ts, which was changed in this PR.

Did I miss something?

@jeanregisser Sorry, you are right, I have reused the video that I created when I was testing the swap flow. But this PR doesn't change that flow. I'll update the video to show the send flow (similar to what I have shown in the demo).

[dievazqu]

@jeanregisser I added the logic in the reducer as you suggested, I'm leaving the PR open in case you want to check that logic. Otherwise, I'm gonna merge this at EOD.