feat(send): add new enter amount screen #4370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4370 +/- ##
==========================================
+ Coverage 84.76% 84.79% +0.02%
==========================================
Files 691 692 +1
Lines 25403 25490 +87
Branches 3357 3369 +12
==========================================
+ Hits 21534 21615 +81
- Misses 3808 3814 +6
Partials 61 61
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
satish-ravi
commented
Oct 24, 2023
| <Text style={styles.title}>{t('sendEnterAmountScreen.title')}</Text> | ||
| <View style={styles.inputContainer}> | ||
| <View style={styles.inputRow}> | ||
| <TextInput |
There was a problem hiding this comment.
This is largely copied from src/swap/SwapAmountInput.tsx. We could make this DRY by making a wrapper TextInput component, but we'd need a bunch of style overrides so wasn't sure if it was worth it.
MuckT
reviewed
Oct 24, 2023
MuckT
approved these changes
Oct 24, 2023
satish-ravi
added a commit
that referenced
this pull request
Nov 6, 2023
### Description Addressing a todo from #4370 to complete the last used token id feature ### Test plan Manually by doing a send and checking that the token defaults to the last sent token on the new send amount screen and also checked the redux state on flipper ### Related issues - na ### Backwards compatibility Yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds new enter amount screen for multichain sends. Also
Test plan
Unit tests, manual
ios-send-enter-amount.mp4
Related issues
Backwards compatibility
Yes