Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update resolutions to fix vulnerabilities #418

Merged
merged 2 commits into from
May 27, 2021
Merged

Conversation

gnardini
Copy link
Contributor

Description

The vulnerabilities check has been failing lately. Updated a few packages to make it pass.

Other changes

N/A

Tested

CI passes

How others should test

Make sure everything in general works well

Related issues

  • Fixes #

Backwards compatibility

N/A

@gnardini gnardini requested a review from a team May 27, 2021 21:38
Copy link
Contributor

@tarikbellamine tarikbellamine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@tarikbellamine tarikbellamine added the automerge Have PR merge automatically when checks pass label May 27, 2021
@mergify mergify bot merged commit 5059e0f into main May 27, 2021
@mergify mergify bot deleted the fix-vulnerabilities branch May 27, 2021 22:25
@ValoraQA
Copy link

ValoraQA commented Jun 4, 2021

Hi @tarikbellamine @gnardini Can you please let us know if we need to test anything in this if yes can you provide more information.
Thanks!

@MuckT
Copy link
Collaborator

MuckT commented Jun 4, 2021

@Celoqa This automated test that was previously failing and is now passing in Circle Ci: working as intended.

satish-ravi added a commit that referenced this pull request Mar 1, 2023
### Description

This was added to fix a vulnerability
(#418). This package is
sub-dependency of react-native-gesture-hander@v1. Since upgrading v2
(#3440), this is no longer
needed.

### Test plan

CI

### Related issues

N/A

### Backwards compatibility

Yes

Co-authored-by: Tom McGuire <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants