Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove react-celo and update walletconnect v2 link #4163

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

MuckT
Copy link
Collaborator

@MuckT MuckT commented Sep 6, 2023

Description

Removes outdated recommendation for dapps to use react-celo which is now end of life and instead recommends @celo/rainbowkit-celo and web3modal. Also replaces a dead link for WalletConnect Docs.

Test plan

N/A

Related issues

react-celo end-of-life (EOL) process #364

Backwards compatibility

Yes

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #4163 (67187f9) into main (85f4a99) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4163   +/-   ##
=======================================
  Coverage   83.57%   83.57%           
=======================================
  Files         716      716           
  Lines       26126    26126           
  Branches     3351     3351           
=======================================
+ Hits        21835    21836    +1     
+ Misses       4224     4223    -1     
  Partials       67       67           

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85f4a99...67187f9. Read the comment docs.

Copy link
Member

@jeanregisser jeanregisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@MuckT MuckT enabled auto-merge (squash) September 7, 2023 17:05
@MuckT MuckT merged commit 107ce19 into main Sep 7, 2023
@MuckT MuckT deleted the tomm/docs-remove-react-celo branch September 7, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants