-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(modal): modal service wip #2047
Conversation
… open modaol with component
9aec2e0
to
62ae2c4
Compare
Codecov Report
@@ Coverage Diff @@
## development #2047 +/- ##
==============================================
- Coverage 87.16% 86.7% -0.47%
==============================================
Files 85 85
Lines 2267 2459 +192
Branches 293 334 +41
==============================================
+ Hits 1976 2132 +156
- Misses 188 213 +25
- Partials 103 114 +11
Continue to review full report at Codecov.
|
Tested. Found next issues:
|
Tested. Looks good now |
Conflicts: demo/src/app/components/+modal/demos/index.ts demo/src/app/components/+modal/modal-section.component.ts
Tested, looks good. Notice: two unit test are failed |
Awesome work. Can't wait to refactor my code. |
one more PR to merge |
later today or tomorrow |
Hi! How can i encapsule my modal component. I dont want to write moal header body.. other element in my component templete. I am using components normal pages. But sometimes i need to open them in modal other pages. I did its working well. But look like ugly. I want to encapsule my component templete another templete. Open component inside another templete. How can i do that? |
WIP
fixes #1998
fixes #1995
fixes #1830
fixes #1181
fixes #579
todo: