Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (acordion) space beetween accordion groups #2014

Merged
merged 1 commit into from
Jun 27, 2017
Merged

fix (acordion) space beetween accordion groups #2014

merged 1 commit into from
Jun 27, 2017

Conversation

artemvfrolov
Copy link
Contributor

@artemvfrolov artemvfrolov commented May 31, 2017

fixed #1854

@codecov
Copy link

codecov bot commented May 31, 2017

Codecov Report

Merging #2014 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #2014   +/-   ##
============================================
  Coverage        87.13%   87.13%           
============================================
  Files               85       85           
  Lines             2262     2262           
  Branches           292      292           
============================================
  Hits              1971     1971           
  Misses             188      188           
  Partials           103      103
Impacted Files Coverage Δ
src/accordion/accordion-group.component.ts 96.15% <ø> (ø) ⬆️
src/accordion/accordion.component.ts 95% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ed0c06...401b84e. Read the comment docs.

@YevheniiaMazur
Copy link

YevheniiaMazur commented Jun 6, 2017

Tested. For bootstrap 3 spaces was fixed. For bootstrap 4 there are no spaces, but this accordion style is used in bootstrap 4 https://v4-alpha.getbootstrap.com/components/collapse/

<ng-content select="[accordion-heading]"></ng-content>
<div class="panel card" [ngClass]="panelClass">
<div class="panel-heading card-header" role="tab" (click)="toggleOpen($event)">
<div class="panel-title card-title">

This comment was marked as off-topic.

@valorkin valorkin merged commit ad2da54 into valor-software:development Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No space beetween accordion groups
4 participants