Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typeahead directive for AoT #1083

Closed

Conversation

isaacplmann
Copy link

The HostListeners need to be public if compiling with AoT and the events are being bound to some other function in the app code as well.

This PR fixes this scenario when AoT compiling:

<input [typeahead]="list" (focus)="someFunction($event)" (blur)="someFunction($event)">

@codecov-io
Copy link

codecov-io commented Oct 5, 2016

Current coverage is 89.60% (diff: 100%)

Merging #1083 into development will not change coverage

@@           development      #1083   diff @@
=============================================
  Files               26         26          
  Lines              789        789          
  Methods            143        143          
  Messages             0          0          
  Branches           116        116          
=============================================
  Hits               707        707          
  Misses              82         82          
  Partials             0          0          

Powered by Codecov. Last update 6f2517c...5221730

@Martin-Luft
Copy link
Contributor

#1086 was merged -> close this PR

@Martin-Luft Martin-Luft closed this Oct 6, 2016
@valorkin
Copy link
Member

valorkin commented Oct 6, 2016

@isaacplmann thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants