Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebrand the Lua debugger #603

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

zuiderkwast
Copy link
Contributor

No description provided.

Signed-off-by: Viktor Söderqvist <[email protected]>
@zuiderkwast
Copy link
Contributor Author

Tested manually with ./valkey-cli --ldb --eval dummy.lua where the file contains

local x = server.call("get", "k")
server.breakpoint()
server.debug("hello server.debug")
redis.breakpoint()
redis.debug("hello redis.debug")
return x

@zuiderkwast zuiderkwast requested a review from PingXie June 6, 2024 01:30
Signed-off-by: Viktor Söderqvist <[email protected]>
Signed-off-by: Viktor Söderqvist <[email protected]>
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.

Project coverage is 70.02%. Comparing base (0700c44) to head (a3d9b0d).
Report is 2 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable     #603      +/-   ##
============================================
- Coverage     70.07%   70.02%   -0.06%     
============================================
  Files           110      110              
  Lines         59991    59993       +2     
============================================
- Hits          42038    42008      -30     
- Misses        17953    17985      +32     
Files Coverage Δ
src/script_lua.c 90.14% <100.00%> (ø)
src/valkey-cli.c 51.49% <0.00%> (-0.08%) ⬇️
src/eval.c 56.07% <58.33%> (+0.04%) ⬆️

... and 8 files with indirect coverage changes

@zuiderkwast zuiderkwast merged commit 278ce0c into valkey-io:unstable Jun 6, 2024
18 checks passed
@zuiderkwast zuiderkwast deleted the rebrand-lua-debugger branch June 6, 2024 17:53
advaMosh pushed a commit to advaMosh/valkey that referenced this pull request Jun 10, 2024
Signed-off-by: Viktor Söderqvist <[email protected]>
Signed-off-by: Adva Moshkovitz <[email protected]>
naglera pushed a commit to naglera/placeholderkv that referenced this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants