Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dict with new hashtable for sets datatype #1176

Merged
merged 2 commits into from
Dec 14, 2024

Revert renamed variable "myhashset" in test case

1f51a2f
Select commit
Loading
Failed to load commit list.
Merged

Replace dict with new hashtable for sets datatype #1176

Revert renamed variable "myhashset" in test case
1f51a2f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 14, 2024 in 1s

66.64% (-4.27%) compared to 5f7fe9e

View this Pull Request on Codecov

66.64% (-4.27%) compared to 5f7fe9e

Details

Codecov Report

Attention: Patch coverage is 75.96567% with 56 lines in your changes missing coverage. Please review.

Project coverage is 66.64%. Comparing base (5f7fe9e) to head (1f51a2f).
Report is 9 commits behind head on unstable.

Files with missing lines Patch % Lines
src/module.c 0.00% 25 Missing ⚠️
src/debug.c 0.00% 14 Missing ⚠️
src/defrag.c 68.18% 7 Missing ⚠️
src/rdb.c 85.71% 3 Missing ⚠️
src/server.c 0.00% 3 Missing ⚠️
src/db.c 92.85% 2 Missing ⚠️
src/t_set.c 97.29% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1176      +/-   ##
============================================
- Coverage     70.90%   66.64%   -4.27%     
============================================
  Files           119      119              
  Lines         64631    64693      +62     
============================================
- Hits          45828    43116    -2712     
- Misses        18803    21577    +2774     
Files with missing lines Coverage Δ
src/hashtable.c 75.88% <100.00%> (+1.67%) ⬆️
src/lazyfree.c 86.11% <100.00%> (ø)
src/object.c 82.13% <100.00%> (+1.46%) ⬆️
src/server.h 100.00% <ø> (ø)
src/t_zset.c 95.66% <100.00%> (-0.01%) ⬇️
src/zmalloc.c 82.74% <100.00%> (+0.13%) ⬆️
src/db.c 89.55% <92.85%> (+0.04%) ⬆️
src/t_set.c 97.84% <97.29%> (+0.33%) ⬆️
src/rdb.c 76.74% <85.71%> (+0.28%) ⬆️
src/server.c 10.44% <0.00%> (-77.02%) ⬇️
... and 3 more

... and 14 files with indirect coverage changes