Fix default value of primary-reboot-down-after-period in sentinel.conf #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since in here the monitor value is mymaster, we need to make sure the primary name is the same, otherwise the default configuration cannot start sentinel. ``` sentinel monitor mymaster 127.0.0.1 6379 2 ``` The following error occurs when the default configuration is started: ``` *** FATAL CONFIG FILE ERROR (Version 255.255.255) *** Reading the configuration file, at line 358 >>> 'SENTINEL primary-reboot-down-after-period myprimary 0' No such master with specified name. ``` Introduced in valkey-io#647. Signed-off-by: Binbin <[email protected]>
enjoy-binbin
added
the
release-notes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1040 +/- ##
============================================
+ Coverage 70.58% 70.62% +0.03%
============================================
Files 114 114
Lines 61670 61670
============================================
+ Hits 43530 43553 +23
+ Misses 18140 18117 -23 |
hwware
approved these changes
Sep 17, 2024
madolson
pushed a commit
to madolson/valkey
that referenced
this pull request
Sep 30, 2024
valkey-io#1040) Since in here the monitor value is mymaster, we need to make sure the primary name is the same, otherwise the default configuration cannot start sentinel. ``` sentinel monitor mymaster 127.0.0.1 6379 2 ``` The following error occurs when the default configuration is started: ``` *** FATAL CONFIG FILE ERROR (Version 255.255.255) *** Reading the configuration file, at line 358 >>> 'SENTINEL primary-reboot-down-after-period myprimary 0' No such master with specified name. ``` Introduced in valkey-io#647. Signed-off-by: Binbin <[email protected]>
PingXie
pushed a commit
to PingXie/valkey
that referenced
this pull request
Oct 9, 2024
valkey-io#1040) Since in here the monitor value is mymaster, we need to make sure the primary name is the same, otherwise the default configuration cannot start sentinel. ``` sentinel monitor mymaster 127.0.0.1 6379 2 ``` The following error occurs when the default configuration is started: ``` *** FATAL CONFIG FILE ERROR (Version 255.255.255) *** Reading the configuration file, at line 358 >>> 'SENTINEL primary-reboot-down-after-period myprimary 0' No such master with specified name. ``` Introduced in valkey-io#647. Signed-off-by: Binbin <[email protected]>
naglera
pushed a commit
to naglera/placeholderkv
that referenced
this pull request
Oct 10, 2024
valkey-io#1040) Since in here the monitor value is mymaster, we need to make sure the primary name is the same, otherwise the default configuration cannot start sentinel. ``` sentinel monitor mymaster 127.0.0.1 6379 2 ``` The following error occurs when the default configuration is started: ``` *** FATAL CONFIG FILE ERROR (Version 255.255.255) *** Reading the configuration file, at line 358 >>> 'SENTINEL primary-reboot-down-after-period myprimary 0' No such master with specified name. ``` Introduced in valkey-io#647. Signed-off-by: Binbin <[email protected]> Signed-off-by: naglera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since in here the monitor value is mymaster, we need to make sure the primary
name is the same, otherwise the default configuration cannot start sentinel.
The following error occurs when the default configuration is started:
Introduced in #647.