Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test failure] Migrated replica reports zero repl offset and rank #967

Closed
hwware opened this issue Aug 29, 2024 · 2 comments · Fixed by #984
Closed

[Test failure] Migrated replica reports zero repl offset and rank #967

hwware opened this issue Aug 29, 2024 · 2 comments · Fixed by #984
Assignees
@enjoy-binbin
Labels
test-failure An issue indicating a test failure

Comments

@hwware
Copy link
Member

hwware commented Aug 29, 2024

Please check the following 2 failure cases, this failed case usually happens when new commit is pushed

*** [err]: Migrated replica reports zero repl offset and rank, and fails to win election - shutdown in tests/unit/cluster/replica-migration.tcl
Failover does not happened

https://github.com/valkey-io/valkey/actions/runs/10610749447/job/29408820341?pr=966
https://github.com/valkey-io/valkey/actions/runs/10617137562/job/29429211376?pr=962
@hwware hwware added the test-failure An issue indicating a test failure label Aug 29, 2024
@enjoy-binbin enjoy-binbin self-assigned this Aug 30, 2024
@madolson madolson moved this to Todo in Valkey 8.0 Sep 2, 2024
@madolson
Copy link
Member

madolson commented Sep 2, 2024

This is a new test for Valkey 8.0, make sure this is passing reliably before GA.

@enjoy-binbin
Copy link
Member

https://github.com/valkey-io/valkey/actions/runs/10610749447/job/29408820341?pr=966
https://github.com/valkey-io/valkey/actions/runs/10617137562/job/29429211376?pr=962

this two links i think both of these require a rebase or merge to catch up with the new code, there are some fixes in unstable that i think can work.

https://github.com/valkey-io/valkey/actions/runs/10658482333/job/29539604703#step:8:4165
As for the new ones that appeared today, I will check it out tomorrow morning (China time), i think i may need to skip these checks to avoid this false positive.

enjoy-binbin added a commit to enjoy-binbin/valkey that referenced this issue Sep 3, 2024
@enjoy-binbin
Avoid false positive in election tests
1a1c405 
The node may not be able to initiate an election in time due to
problems with cluster communication. If an election is initiated,
make sure its offset is 0.

Closes valkey-io#967.

Signed-off-by: Binbin <[email protected]>
@enjoy-binbin enjoy-binbin mentioned this issue Sep 3, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Valkey 8.0 Sep 13, 2024
PingXie pushed a commit to PingXie/valkey that referenced this issue Sep 13, 2024
@enjoy-binbin @PingXie
Avoid false positive in election tests (valkey-io#984)
c464ec7 
The node may not be able to initiate an election in time due to
problems with cluster communication. If an election is initiated,
make sure its offset is 0.

Closes valkey-io#967.

Signed-off-by: Binbin <[email protected]>
PingXie pushed a commit to PingXie/valkey that referenced this issue Sep 13, 2024
@enjoy-binbin @PingXie
Avoid false positive in election tests (valkey-io#984)
8c96da6 
The node may not be able to initiate an election in time due to
problems with cluster communication. If an election is initiated,
make sure its offset is 0.

Closes valkey-io#967.

Signed-off-by: Binbin <[email protected]>
Signed-off-by: Ping Xie <[email protected]>
PingXie pushed a commit to PingXie/valkey that referenced this issue Sep 14, 2024
@enjoy-binbin @PingXie
Avoid false positive in election tests (valkey-io#984)
ce74249 
The node may not be able to initiate an election in time due to
problems with cluster communication. If an election is initiated,
make sure its offset is 0.

Closes valkey-io#967.

Signed-off-by: Binbin <[email protected]>
Signed-off-by: Ping Xie <[email protected]>
PingXie pushed a commit to PingXie/valkey that referenced this issue Sep 14, 2024
@enjoy-binbin @PingXie
Avoid false positive in election tests (valkey-io#984)
bbe7c5b 
The node may not be able to initiate an election in time due to
problems with cluster communication. If an election is initiated,
make sure its offset is 0.

Closes valkey-io#967.

Signed-off-by: Binbin <[email protected]>
Signed-off-by: Ping Xie <[email protected]>
PingXie pushed a commit to PingXie/valkey that referenced this issue Sep 14, 2024
@enjoy-binbin @PingXie
Avoid false positive in election tests (valkey-io#984)
2f9958b 
The node may not be able to initiate an election in time due to
problems with cluster communication. If an election is initiated,
make sure its offset is 0.

Closes valkey-io#967.

Signed-off-by: Binbin <[email protected]>
Signed-off-by: Ping Xie <[email protected]>
enjoy-binbin added a commit to enjoy-binbin/valkey that referenced this issue Sep 14, 2024
@enjoy-binbin
Avoid false positive in election tests (valkey-io#984)
84f8897 
The node may not be able to initiate an election in time due to
problems with cluster communication. If an election is initiated,
make sure its offset is 0.

Closes valkey-io#967.

Signed-off-by: Binbin <[email protected]>
PingXie pushed a commit to PingXie/valkey that referenced this issue Sep 14, 2024
@enjoy-binbin @PingXie
Avoid false positive in election tests (valkey-io#984)
22565a0 
The node may not be able to initiate an election in time due to
problems with cluster communication. If an election is initiated,
make sure its offset is 0.

Closes valkey-io#967.

Signed-off-by: Binbin <[email protected]>
Signed-off-by: Ping Xie <[email protected]>
PingXie pushed a commit to PingXie/valkey that referenced this issue Sep 14, 2024
@enjoy-binbin @PingXie
Avoid false positive in election tests (valkey-io#984)
8208ce9 
The node may not be able to initiate an election in time due to
problems with cluster communication. If an election is initiated,
make sure its offset is 0.

Closes valkey-io#967.

Signed-off-by: Binbin <[email protected]>
Signed-off-by: Ping Xie <[email protected]>
PingXie pushed a commit that referenced this issue Sep 15, 2024
@enjoy-binbin @PingXie
Avoid false positive in election tests (#984)
09ed2fc 
The node may not be able to initiate an election in time due to
problems with cluster communication. If an election is initiated,
make sure its offset is 0.

Closes #967.

Signed-off-by: Binbin <[email protected]>
Signed-off-by: Ping Xie <[email protected]>
naglera pushed a commit to naglera/placeholderkv that referenced this issue Oct 10, 2024
@enjoy-binbin @naglera
Avoid false positive in election tests (valkey-io#984)
334289a 
The node may not be able to initiate an election in time due to
problems with cluster communication. If an election is initiated,
make sure its offset is 0.

Closes valkey-io#967.

Signed-off-by: Binbin <[email protected]>
Signed-off-by: naglera <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enjoy-binbin enjoy-binbin

Labels
test-failure An issue indicating a test failure
Projects
Valkey 8.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid false positive in election tests enjoy-binbin/valkey
3 participants
@enjoy-binbin @madolson @hwware