Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically configure threadpool size based on physical cpu core count. #60
base: main
Are you sure you want to change the base?
Automatically configure threadpool size based on physical cpu core count. #60
Changes from all commits
6bf2838
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest that we emit some error message and return
std::thread::hardware_concurrency()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yairgott a std:.error message (or) run time error message (or) just print a standard error message in console before you return the std::thread::hardware_concurrency()?, could you be little more specific on what you mean by "emit"?.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think i will probably use some thing like this here: wdyt?.
std::cerr << "Warning: Could not read /proc/cpuinfo. Falling back to std::thread::hardware_concurrency().\n";
return std::thread::hardware_concurrency();
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets break the parsing into its own function and add a parsing unittest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets move all the threading related logic from utils.h/cc to here: https://github.com/valkey-io/valkey-search/blob/main/vmsdk/src/utils.h#L55-L108
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, We could do this in another PR, there may be some changes in the over all code base, if i do this, specially when i try to change the utils.h/cc dependent src files, i perhaps have to do some more changes, so in my suggestion is we could keep it for refractoring issue and i would gladly work on that, Wdyt? just to keep it simple for this specific issue.