Add missing step names. #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barshaul
reviewed
Sep 10, 2023
.github/workflows/rust.yml
Outdated
|
|
||
| - uses: ./.github/workflows/lint-rust | ||
| with: | ||
| cargo-toml-folder: ./benchmarks/rust | ||
| name: lintbenchmark |
I wasted a lot of time by trying to debug issues in the wrong step. Now all steps will be properly named, and easy to understand where failures happen.
shachlanAmazon
force-pushed
the
rule-names
branch
from
b5acdbf to
f784f26
Compare
Yury-Fridlyand
added a commit
that referenced
this pull request
Sep 10, 2024
) * returning a record replacement with glide strings. * Node: Add binary variant to `PUBSUB NUMSUB` and `PUBSUB SHARDNUMSUB` (#419) * Updated PubSub shardnumsub and numsub commands * Fix tests. * Add binary variant to PUBSUB subscribe commands * Fix processing cluster response. Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Yi-Pin Chen <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]> Co-authored-by: Yi-Pin Chen <[email protected]>
janhavigupta007
pushed a commit
to janhavigupta007/glide-for-redis
that referenced
this pull request
Sep 11, 2024
…lkey-io#2207) * returning a record replacement with glide strings. * Node: Add binary variant to `PUBSUB NUMSUB` and `PUBSUB SHARDNUMSUB` (valkey-io#419) * Updated PubSub shardnumsub and numsub commands * Fix tests. * Add binary variant to PUBSUB subscribe commands * Fix processing cluster response. Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Yi-Pin Chen <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]> Co-authored-by: Yi-Pin Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasted a lot of time by trying to debug issues in the wrong step. Now all steps will be properly named, and easy to understand where failures happen.