Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: update return types & response handlers for scan commands #2956

Merged
merged 2 commits into from
Jan 18, 2025

Conversation

tjzhang-BQ
Copy link
Collaborator

@tjzhang-BQ tjzhang-BQ commented Jan 15, 2025

Issue link

This Pull Request is linked to issue (URL): #2878

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@tjzhang-BQ tjzhang-BQ added the go golang wrapper label Jan 15, 2025
@tjzhang-BQ tjzhang-BQ requested a review from a team as a code owner January 15, 2025 23:25
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Collaborator

@yipin-chen yipin-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjzhang-BQ tjzhang-BQ merged commit 96894df into main Jan 18, 2025
17 of 18 checks passed
@tjzhang-BQ tjzhang-BQ deleted the go/tjz-scans branch January 18, 2025 01:13
Maayanshani25 pushed a commit to Maayanshani25/valkey-glide that referenced this pull request Jan 19, 2025
…-io#2956)

* Go: update return types & response handlers for scan commands

Signed-off-by: TJ Zhang <[email protected]>
edlng pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jan 20, 2025
…-io#2956)

* Go: update return types & response handlers for scan commands

Signed-off-by: TJ Zhang <[email protected]>
Signed-off-by: Edward Liang <[email protected]>
eifrah-aws pushed a commit to eifrah-aws/glide-for-redis that referenced this pull request Jan 23, 2025
…-io#2956)

* Go: update return types & response handlers for scan commands

Signed-off-by: TJ Zhang <[email protected]>
barshaul pushed a commit to barshaul/glide-for-redis that referenced this pull request Jan 28, 2025
…-io#2956)

* Go: update return types & response handlers for scan commands

Signed-off-by: TJ Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go golang wrapper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants