Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node: Add command JSON.CLEAR #2566

Merged
merged 7 commits into from
Nov 7, 2024
Merged

Node: Add command JSON.CLEAR #2566

merged 7 commits into from
Nov 7, 2024

Conversation

jonathanl-bq
Copy link
Collaborator

@jonathanl-bq jonathanl-bq commented Nov 1, 2024 •
edited
Loading

Issue link

This Pull Request is linked to issue (URL): #2375

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

@jonathanl-bq
Implement JSON clear command
4dd6ab7 
Signed-off-by: Jonathan Louie <[email protected]>
@jonathanl-bq
Add tests for JSON clear
ca81396 
Signed-off-by: Jonathan Louie <[email protected]>
@jonathanl-bq jonathanl-bq added the node Node.js wrapper label Nov 1, 2024
@jonathanl-bq jonathanl-bq changed the base branch from main to release-1.2 November 1, 2024 18:43
@jonathanl-bq jonathanl-bq marked this pull request as ready for review November 1, 2024 18:47
@jonathanl-bq jonathanl-bq requested a review from a team as a code owner November 1, 2024 18:47
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Nov 1, 2024
Closed
11 tasks
acarbonetto
acarbonetto approved these changes Nov 1, 2024
View reviewed changes
@jonathanl-bq @acarbonetto
Apply suggestions from code review
1f74002 
Co-authored-by: Andrew Carbonetto <[email protected]>
Signed-off-by: jonathanl-bq <[email protected]>
@jonathanl-bq
Run Prettier
bf04bde 
Signed-off-by: Jonathan Louie <[email protected]>
@Yury-Fridlyand
Copy link
Collaborator

CI is red please fix

@jonathanl-bq
Copy link
Collaborator Author

image

@jonathanl-bq jonathanl-bq merged commit b7e9d10 into release-1.2 Nov 7, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@acarbonetto acarbonetto acarbonetto approved these changes

Assignees
No one assigned
Labels
node Node.js wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathanl-bq @Yury-Fridlyand @acarbonetto