Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python - Implement JSON.OBJLEN command functionality #2495

Merged
merged 11 commits into from
Oct 28, 2024
Merged

Python - Implement JSON.OBJLEN command functionality #2495

merged 11 commits into from
Oct 28, 2024

Conversation

BoazBD
Copy link
Collaborator

@BoazBD BoazBD commented Oct 22, 2024 •
edited
Loading

Issue link

This Pull Request is linked to issue (URL): #2412

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

@BoazBD BoazBD marked this pull request as ready for review October 22, 2024 12:59
@BoazBD BoazBD requested a review from a team as a code owner October 22, 2024 12:59
@BoazBD BoazBD requested a review from Yury-Fridlyand October 22, 2024 12:59
@Yury-Fridlyand Yury-Fridlyand added the python Python wrapper label Oct 22, 2024
@shohamazon
Copy link
Collaborator

shohamazon commented Oct 22, 2024 •
edited
Loading

Please wait for my review before you merge 🙃

@shohamazon shohamazon mentioned this pull request Oct 27, 2024
Closed
22 tasks
@BoazBD
fix shoham comments
c425591 
Signed-off-by: BoazBD <[email protected]>
@BoazBD
fix docstring
59ffaeb 
Signed-off-by: BoazBD <[email protected]>
@BoazBD
format
8efd620 
Signed-off-by: BoazBD <[email protected]>
@shohamazon shohamazon merged commit 52dd474 into release-1.2 Oct 28, 2024
16 checks passed
@shohamazon shohamazon deleted the json.objlen branch October 28, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@shohamazon shohamazon shohamazon approved these changes

Assignees
No one assigned
Labels
python Python wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BoazBD @shohamazon @Yury-Fridlyand