-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: adds JSON.ARRTRIM command #2457
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
Please fix CI, resolve conflicts and add changelog
Trims an array at the specified `path` within the JSON document stored at `key` so that it becomes a subarray [start, end], both inclusive.\n | ||
If `start` < 0, it is treated as 0.\n | ||
If `end` >= size (size of the array), it is treated as size-1.\n | ||
If `start` >= size or `start` > `end`, the array is emptied and 0 is returned.\n |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't include \n
s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me know what you thing, removed for now
Signed-off-by: Shoham Elias <[email protected]>
8b8bda5
to
8300273
Compare
Signed-off-by: Shoham Elias <[email protected]>
8300273
to
ac7d8cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Issue link
This Pull Request is linked to issue (URL): #645
Checklist
Before submitting the PR make sure the following are checked: