Python: add JSON.TYPE command #2409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Muhammad Awawdi <[email protected]>
Muhammad-awawdi-amazon
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Muhammad Awawdi <[email protected]>
Muhammad-awawdi-amazon
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Muhammad Awawdi <[email protected]>
Muhammad-awawdi-amazon
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Muhammad Awawdi <[email protected]>
Muhammad-awawdi-amazon
temporarily deployed
to
AWS_ACTIONS
GitHub Actions
Inactive
shohamazon
reviewed
Oct 9, 2024
| result = await json.type(glide_client, key, "$.key6") | ||
| assert result == [b"bool"] | ||
|
|
||
| # Check for non-existent path $.key7 |
There was a problem hiding this comment.
add a similar test for legacy path which will return None
There was a problem hiding this comment.
add a test for legacy + multiple path match
127.0.0.1:6379> json.set k1 . '{"a": 1, "nested": {"a": 2, "b": 3}}'
OK
127.0.0.1:6379> json.type k1 ..a
integer
|
|
||
| # Check for invalid path format | ||
| result = await json.type(glide_client, key, "$.key1.key2") # Invalid path | ||
| assert result == [] |
There was a problem hiding this comment.
add a test for non existing key with 2 types of path
Co-authored-by: Shoham Elias <[email protected]> Signed-off-by: Muhammad-awawdi-amazon <[email protected]>
Muhammad-awawdi-amazon
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Muhammad Awawdi <[email protected]>
Muhammad-awawdi-amazon
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Muhammad Awawdi <[email protected]>
Muhammad-awawdi-amazon
temporarily deployed
to
AWS_ACTIONS
GitHub Actions
Inactive
shohamazon
reviewed
Oct 9, 2024
Co-authored-by: Shoham Elias <[email protected]> Signed-off-by: Muhammad-awawdi-amazon <[email protected]>
Muhammad-awawdi-amazon
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
7 tasks
Signed-off-by: Muhammad Awawdi <[email protected]>
Muhammad-awawdi-amazon
temporarily deployed
to
AWS_ACTIONS
GitHub Actions
Inactive
shohamazon
approved these changes
Oct 9, 2024
prateek-kumar-improving
pushed a commit
that referenced
this pull request
Oct 9, 2024
--------- Signed-off-by: Muhammad Awawdi <[email protected]> Signed-off-by: Muhammad-awawdi-amazon <[email protected]> Co-authored-by: Shoham Elias <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.