Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node: Fix linter config. #2272

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Node: Fix linter config. #2272

merged 3 commits into from
Sep 11, 2024

Conversation

Yury-Fridlyand
Copy link
Collaborator

Address unresolved issues in #2263

Now npm run lint will run both linters, npm run lint:fix will try to apply fixes from both as well

@Yury-Fridlyand
Fix linter config.
7ad644b 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand added the node Node.js wrapper label Sep 11, 2024
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner September 11, 2024 02:50
avifenesh
avifenesh approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@avifenesh avifenesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@acarbonetto acarbonetto merged commit bc52197 into valkey-io:main Sep 11, 2024
15 checks passed
@acarbonetto acarbonetto deleted the node/yuryf-linter-fix branch September 11, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avifenesh avifenesh avifenesh approved these changes

@acarbonetto acarbonetto acarbonetto approved these changes

@yipin-chen yipin-chen yipin-chen approved these changes

Assignees
No one assigned
Labels
node Node.js wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yury-Fridlyand @avifenesh @acarbonetto @yipin-chen