Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: Add Binary support for stream commands, part 2 #2222

Conversation

jamesx-improving
Copy link
Collaborator

Commands included:

  • XINFO CONSUMERS
  • XINFO STREAM
  • XLEN
  • XPENDING
  • XRANGE
  • XREAD
  • XREADGROUP
  • XREVRANGE
  • XTRIM

@jamesx-improving jamesx-improving requested a review from a team as a code owner September 4, 2024 00:52
@Yury-Fridlyand Yury-Fridlyand added the node Node.js wrapper label Sep 4, 2024
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add changelog and fix linter

Copy link
Collaborator

@tjzhang-BQ tjzhang-BQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to amend commit with signoff

Signed-off-by: James Xin <[email protected]>
@jamesx-improving jamesx-improving force-pushed the node/jamesx-valkey-270-stream-commands-pt-2 branch from f89a47b to 1d719a4 Compare September 4, 2024 23:14
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand merged commit 8959ad1 into valkey-io:main Sep 5, 2024
9 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the node/jamesx-valkey-270-stream-commands-pt-2 branch September 5, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node Node.js wrapper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants