Node: add binary support for PubSub commands, part 1 #2201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yi-Pin Chen <[email protected]>
Signed-off-by: Yi-Pin Chen <[email protected]>
Signed-off-by: Yi-Pin Chen <[email protected]>
Signed-off-by: Yi-Pin Chen <[email protected]>
Yury-Fridlyand
approved these changes
Aug 27, 2024
acarbonetto
approved these changes
Aug 28, 2024
jonathanl-bq
approved these changes
Aug 28, 2024
prateek-kumar-improving
approved these changes
Aug 28, 2024
Signed-off-by: Yi-Pin Chen <[email protected]>
yipin-chen
added a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Sep 4, 2024
* Node: add binary support for PubSub commands, part 1 --------- Signed-off-by: Yi-Pin Chen <[email protected]>
yipin-chen
added a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Sep 5, 2024
* Node: add binary support for PubSub commands, part 1 (valkey-io#2201) * Add binary variant to PUBSUB subscribe commands --------- Signed-off-by: Yi-Pin Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PubSub (part 1):
PublishSPublishPUBSUB CHANNELSPUBSUB SHARDCHANNELSPUBSUB NUMPAT- No change requiredFor the remaining PubSub commands,
Record< >are used. They will be handled in the next PR.