Added factory method to create a new client initilized with connection

python/src/__init__.py

@@ -1,11 +1,6 @@
 from babushka import Client
 
 from src.async_client import RedisAsyncClient
-from src.config import ClientConfiguration, ClusterClientConfiguration
+from src.config import ClientConfiguration
 
-__all__ = [
-    "RedisAsyncClient",
-    "Client",
-    "ClientConfiguration",
-    "ClusterClientConfiguration",
-]
+__all__ = ["RedisAsyncClient", "Client", "ClientConfiguration"]

python/src/async_client.py

@@ -6,16 +6,17 @@
 
 
 class RedisAsyncClient(CoreCommands):
-    def __init__(
-        self,
-        config: ClientConfiguration = ClientConfiguration.get_default_config(),
+    @classmethod
+    async def create(
+        cls, config: ClientConfiguration = ClientConfiguration.get_default_config()
     ):
+        self = RedisAsyncClient()
         self.config = config
-        self.connection = None
+        self.connection = await self._create_multiplexed_conn()
+        return self
 
-    async def create_multiplexed_conn(self):
-        self.connection = await Client.new(to_url(**self.config.config_args))
-        return self.connection
+    async def _create_multiplexed_conn(self):
+        return await Client.new(to_url(**self.config.config_args))
 
     async def execute_command(self, command, *args, **kwargs):
         conn_rust_func = getattr(self.connection, command)

python/src/config.py

@@ -41,24 +41,3 @@ def get_default_config():
         return ClientConfiguration(
             host=DEFAULT_HOST, port=DEFAULT_PORT, db=0, tls_enabled=False
         )
-
-
-class ClusterClientConfiguration(BaseClientConfiguration):
-    CLUSTER_SPECIFIC_KEYS = {"read_from_replicas"}
-
-    def __init__(self, **kwargs):
-        allowed_keys = ClusterClientConfiguration.CLUSTER_SPECIFIC_KEYS.copy().union(
-            BASE_ALLOWED_KEYS
-        )
-        super(ClusterClientConfiguration, self).__init__(
-            allowed_keys=allowed_keys, **kwargs
-        )
-
-    @staticmethod
-    def get_default_config():
-        return ClusterClientConfiguration(
-            host=DEFAULT_HOST,
-            port=DEFAULT_PORT,
-            tls_enabled=False,
-            read_from_replicas=False,
-        )

python/tests/conftest.py

@@ -1,7 +1,7 @@
 import pytest
 
 from src.async_client import RedisAsyncClient
-from src.config import ClusterClientConfiguration
+from src.config import ClientConfiguration
 
 default_host = "localhost"
 default_port = 6379
@@ -28,7 +28,5 @@ async def async_client(request):
     "Get async client for tests"
     host = request.config.getoption("--host")
     port = request.config.getoption("--port")
-    config = ClusterClientConfiguration(host=host, port=port)
-    client = RedisAsyncClient(config)
-    await client.create_multiplexed_conn()
-    return client
+    config = ClientConfiguration(host=host, port=port)
+    return await RedisAsyncClient.create(config)

python/tests/test_config.py

@@ -1,12 +1,4 @@
-from src.config import (DEFAULT_HOST, DEFAULT_PORT, ClientConfiguration,
-                        ClusterClientConfiguration)
-
-
-def test_default_cluster_config():
-    config = ClusterClientConfiguration.get_default_config()
-    assert config.config_args["host"] == DEFAULT_HOST
-    assert config.config_args["port"] == DEFAULT_PORT
-    assert config.config_args["read_from_replicas"] is False
+from src.config import DEFAULT_HOST, DEFAULT_PORT, ClientConfiguration
 
 
 def test_default_client_config():