Fix isFloat('.') === true, closes #443

validatorjs · Oct 20, 2015 · 902cfc9 · 902cfc9
1 parent 825af6a
commit 902cfc9
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,7 @@
 #### HEAD
 
+- Fix the incorrect `isFloat('.') === true`
+  ([#443](https://github.com/chriso/validator.js/pull/443))
 - Added a Norwegian locale to `isMobilePhone()`
   ([#439](https://github.com/chriso/validator.js/pull/439))
 

diff --git a/test/validators.js b/test/validators.js
@@ -676,6 +676,7 @@ describe('Validators', function () {
                 '-.123'
               , '  '
               , ''
+              , '.'
               , 'foo'
             ]
         });

diff --git a/validator.js b/validator.js
@@ -440,7 +440,10 @@
 
     validator.isFloat = function (str, options) {
         options = options || {};
-        return str !== '' && float.test(str) && (!options.hasOwnProperty('min') || str >= options.min) && (!options.hasOwnProperty('max') || str <= options.max);
+        if (str === '' || str === '.') {
+            return false;
+        }
+        return float.test(str) && (!options.hasOwnProperty('min') || str >= options.min) && (!options.hasOwnProperty('max') || str <= options.max);
     };
 
     validator.isDivisibleBy = function (str, num) {
-Original file line number
+Diff line change
@@ Expand Up / @@ -676,6 +676,7 @@ describe('Validators', function () { @@
                     '-.123'
                   , '  '
                   , ''
+                  , '.'
                   , 'foo'
                 ]
             });
@@ Expand Down @@