Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Java 9 and up #120

Merged
merged 6 commits into from
Jul 12, 2018

Conversation

MPParsley
Copy link
Contributor

@MPParsley MPParsley commented Jul 11, 2018

Support for java > 8 is broken.

The code assumes that java -version outputs 1.x:

    if ( java.version[ 0 ] !== '1' || ( java.version[ 0 ] === '1' && java.version[ 2 ] <= '8' ) ) {
      throw new Error( '\nUnsupported Java version used: ' + java.version + '. v1.8 is required!' );
    }

Java 9 java -version:

java version "9.0.4"
Java(TM) SE Runtime Environment (build 9.0.4+11)
Java HotSpot(TM) 64-Bit Server VM (build 9.0.4+11, mixed mode)

Java 10 java -version:

java version "10.0.1" 2018-04-17
Java(TM) SE Runtime Environment 18.3 (build 10.0.1+10)
Java HotSpot(TM) 64-Bit Server VM 18.3 (build 10.0.1+10, mixed mode)

Fixed the check and updated the README to reflect support for Java 8+.

Updated README to reflect support for java 9 and up.
@MPParsley MPParsley changed the title Added Java 9 support for OSX Added Java 9 support and support for OSX Jul 11, 2018
@MPParsley MPParsley mentioned this pull request Jul 11, 2018
@MPParsley MPParsley changed the title Added Java 9 support and support for OSX Added support for Java 9 and up Jul 11, 2018
@jzaefferer
Copy link
Contributor

I don't think grunt-html should be responsible to test the Java version. With composer it's possible to test for the php/java version perhaps a similar approach exists for npm?

Or we remove that check altogether?

All checks have failed

The linter is complaining about some silly missing spaces. Could you check that out?

@MPParsley
Copy link
Contributor Author

Hi @jzaefferer, I fixed the linter issues. I'm new to this type of JavaScript formatting with spaces all over the place :).

@jzaefferer
Copy link
Contributor

Yeah, its a special style. I stopped using it on newer projects a while ago.

Anyway, this looks fine now, I'll merge. Thanks for the contribution!

@jzaefferer jzaefferer merged commit 406cef4 into validator:master Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants