fix: metrics targetPort https -> 8443 #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artur Shad Nik <[email protected]>
dosubot
bot
added
the
size:XS
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #338 +/- ##
=======================================
Coverage 43.39% 43.39%
=======================================
Files 9 9
Lines 848 848
=======================================
Hits 368 368
Misses 450 450
Partials 30 30 Continue to review full report in Codecov by Sentry.
|
mattwelke
approved these changes
Dec 16, 2024
arturshadnik
pushed a commit
that referenced
this pull request
Dec 17, 2024
🤖 I have created a release *beep* *boop* --- ## [0.3.5](v0.3.4...v0.3.5) (2024-12-16) ### Bug Fixes * metrics targetPort https -> 8443 ([#338](#338)) ([8ed195b](8ed195b)) ### Dependency Updates * **deps:** update all non-major dependencies ([#330](#330)) ([0d1923f](0d1923f)) * **deps:** update all non-major dependencies ([#336](#336)) ([ae1fa60](ae1fa60)) * **deps:** update build digest to 5e4aaa9 ([#332](#332)) ([3996772](3996772)) * **deps:** update build digest to 9734871 ([#339](#339)) ([c6c48ba](c6c48ba)) * **deps:** update github.com/awslabs/amazon-ecr-credential-helper/ecr-login digest to 69e8c24 ([#333](#333)) ([b35eb81](b35eb81)) * **deps:** update module github.com/sigstore/sigstore to v1.8.11 ([#337](#337)) ([65714e1](65714e1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metrics server is exposed on port 8443. This PR updates the metrics service chart value to match this, to ensure it's accessible.