Fixes an NPE and InvalidOperationException. #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm getting this exception a lot in my game, and it's player. [Error : Unity Log] NullReferenceException: Object reference not set to an instance of an object Stack trace: ValheimPlus.UI.HotkeyBar_UpdateIcons_Patch.DisplayAmmoCountsUnderBowHotbarIcon (HotkeyBar __instance, Player player) (at C:/Users/twili/RiderProjects/ValheimPlus/ValheimPlus/UI/HotkeyBar.cs:40) ValheimPlus.UI.HotkeyBar_UpdateIcons_Patch.Postfix (HotkeyBar& __instance, Player& player) (at C:/Users/twili/RiderProjects/ValheimPlus/ValheimPlus/UI/HotkeyBar.cs:21) (wrapper dynamic-method) HotkeyBar.DMD<HotkeyBar::UpdateIcons>(HotkeyBar,Player) HotkeyBar.Update () (at <35c0f7aa1999477788815a7bf78200d7>:0)
Can't modify a collection while you iterate through it without getting an exception. Usually works fine for the player, but it does throw an exception and is bad practice. Could feasibly cause the player an issue if two items were somehow destroyed at once. Stacktrace: [Error : Unity Log] InvalidOperationException: Collection was modified; enumeration operation may not execute. Stack trace: System.Collections.Generic.Dictionary`2+Enumerator[TKey,TValue].MoveNext () (at <695d1cc93cca45069c528c15c9fdd749>:0) ValheimPlus.GameClasses.displayCartsAndBoatsOnMap+Minimap_UpdateMap_Patch.Postfix (Minimap& __instance, Player player, System.Single dt, System.Boolean takeInput) (at C:/Users/twili/RiderProjects/ValheimPlus/ValheimPlus/GameClasses/Minimap.cs:419) (wrapper dynamic-method) Minimap.DMD<Minimap::UpdateMap>(Minimap,Player,single,bool) Minimap.Update () (at <35c0f7aa1999477788815a7bf78200d7>:0)
healiha
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.