attempt to fix infinite loop in isochrones generation #4547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@munckymagik did you have time to give this code a try? |
|
@kevinkreiser just tried it out now with my failing example and it now returns a response 🎉 ✅ |
kevinkreiser
commented
Feb 9, 2024
| @@ -17,10 +17,22 @@ constexpr float METRIC_PADDING = 10.f; | |||
| template <typename PrecisionT> | |||
| std::vector<GeoPoint<PrecisionT>> OriginEdgeShape(const std::vector<GeoPoint<PrecisionT>>& pts, | |||
| double distance_along) { | |||
| // just the endpoint really | |||
| if (distance_along == 0) | |||
There was a problem hiding this comment.
if you are snapped to the end of the edge we just return a segment of zero length at the end
kevinkreiser
commented
Feb 9, 2024
src/thor/isochrone.cc
Outdated
Comment on lines
31
to
33
| // skip 0 length segments | ||
| if (len == 0) | ||
| continue; |
There was a problem hiding this comment.
this is not needed. if len is 0 then it cant change suffix_len which means it cant change the outcome of that if below and get in there and do a divide by 0.
kevinkreiser
commented
Feb 9, 2024
| @@ -1,4 +1,4 @@ | |||
| name: syntax | |||
| name: lint | |||
There was a problem hiding this comment.
i prefer to call it like it is
nilsnolde
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4546
we may still want to protect bresenhams separately but perhaps this is a start