Fix #393 Setting enabled logging levels for all threads change the default for all threads #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e the default for all threads
|
Code Climate has analyzed commit 53344d4 and detected 0 issues on this pull request. View more on Code Climate. |
valfirst
approved these changes
Jun 14, 2023
|
@karstenspang thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #393 Setting enabled logging levels for all threads change the default for all threads
Changing
TestLogger.setEnabledLevelsForAllThreadsas I originally intended turned out to be logically impossible, so I restricted the changes to makeTestLogger.clearandTestLogger.clearAllto behave like their Javadoc says, even aftersetEnabledLevelsForAllThreadshas been called.I also updated the Javadoc for
setEnabledLevelsForAllThreads, removing the note that calling these methods makesclearandclearAllnot behave as expected.I added two new test cases that fail for the unchanged code.