Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add extra jmx metrics #212

Conversation

caiopavanelli
Copy link
Contributor

What this PR does / why we need it:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Verify the work you plan to merge addresses an existing issue (If not, open a new one) (required)
  • Check your branch with helm lint (required)
  • Update version in Chart.yaml according semver rules (required)
  • Substitute annotations section in Chart.yaml annotating implementations (useful for Artifacthub changelog) (required)
  • Update chart README using helm-docs (required)

Which issue(s) this PR fixes:

Fixes #211

Special notes for your reviewer:

The extraMetrics parameter would allow the export of extra jmx metrics like the following.

jmxExporter:
  extraMetrics: |
    - pattern: trino.execution<name=QueryManager><>ExecutionTime.OneMinute.P50
      name: trino_execution_time_one_minute_p50

    - pattern: trino.execution<name=QueryManager><>ExecutionTime.OneMinute.P90
      name: trino_execution_time_one_minute_p90

    - pattern: trino.execution<name=QueryManager><>ExecutionTime.OneMinute.P99
      name: trino_execution_time_one_minute_p99

@valeriano-manassero valeriano-manassero merged commit 7f9d563 into valeriano-manassero:main Jan 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Trino] Parameter to export extra JMX metrics
2 participants