Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore ability to provide fault tolerance config without b64 encoded secret #195

Conversation

cccs-nik
Copy link
Contributor

@cccs-nik cccs-nik commented Dec 7, 2023

What this PR does / why we need it:
Addresses #194 which removed a certain way of providing the fault tolerance config

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Verify the work you plan to merge addresses an existing issue (If not, open a new one) (required)
  • Check your branch with helm lint (required)
  • Update version in Chart.yaml according semver rules (required)
  • Substitute annotations section in Chart.yaml annotating implementations (useful for Artifacthub changelog) (required)
  • Update chart README using helm-docs (required)

Which issue(s) this PR fixes:

Fixes #194

Special notes for your reviewer:

@cccs-nik cccs-nik changed the title Feature/fault tolerance config Restore ability to provide fault tolerance config without b64 encoded secret Dec 7, 2023
@cccs-mmrouet
Copy link
Contributor

Hi, I am wondering if this pr can be looked at and merged as our organization is dependant on this fix to be put back into the chart. Thanks in advance!

@valeriano-manassero valeriano-manassero merged commit 6382a14 into valeriano-manassero:main Dec 22, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[trino] Restore ability to provide fault tolerance config without b64 encoded secret
3 participants