-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jmx-exporter monitoring functionality with servicemonitor #147
Add jmx-exporter monitoring functionality with servicemonitor #147
Conversation
Hi, Ty for the PR. Pls increment minor version in Chart.yaml and regenerate README with helm-docs to pass tests. |
Oops sorry about that, this just a draft. |
No worries and take your time, will merge it when ready 😄 |
a3ae5db
to
e3d7a04
Compare
done! |
Good catch, would you mind to change this line with 1.11.0 too pls? helm-charts/.github/helm-docs.sh Line 4 in 549224c
|
I suggest to change version to 2.7.0 instead of 2.6.2. |
Should we update trino version to the latest also, which is 406 from 380 that is now? |
I have no idea if new version is compatible with the chart. |
f76c17e
to
2a569fa
Compare
No description provided.