Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jmx-exporter monitoring functionality with servicemonitor #147

Merged
merged 4 commits into from
Jan 31, 2023

Conversation

azisi
Copy link
Contributor

@azisi azisi commented Jan 30, 2023

No description provided.

@valeriano-manassero
Copy link
Owner

valeriano-manassero commented Jan 30, 2023

Hi, Ty for the PR. Pls increment minor version in Chart.yaml and regenerate README with helm-docs to pass tests.

@azisi
Copy link
Contributor Author

azisi commented Jan 31, 2023

Oops sorry about that, this just a draft.
I wanted to open the PR in my repo first to clean it up before I open it here 😄

@valeriano-manassero
Copy link
Owner

No worries and take your time, will merge it when ready 😄

@azisi
Copy link
Contributor Author

azisi commented Jan 31, 2023

No worries and take your time, will merge it when ready 😄

done!
btw, i think the lint step in ci.yaml is broken. There is no v1.12.0 helm-docs version.

@valeriano-manassero
Copy link
Owner

i think the lint step in ci.yaml is broken. There is no v1.12.0 helm-docs version.

Good catch, would you mind to change this line with 1.11.0 too pls?

HELM_DOCS_VERSION="1.12.0"

@valeriano-manassero
Copy link
Owner

I suggest to change version to 2.7.0 instead of 2.6.2.
This is because some new parameter is added so it's not just a patch.
wdyt?

@azisi
Copy link
Contributor Author

azisi commented Jan 31, 2023

Should we update trino version to the latest also, which is 406 from 380 that is now?

@valeriano-manassero
Copy link
Owner

Should we update trino version to the latest also, which is 406 from 380 that is now?

I have no idea if new version is compatible with the chart.
I suggest just to make this PR to pas tests (helm-docs needs to be run again). Then you can open another PR for a new version.

@valeriano-manassero valeriano-manassero merged commit cea6ad7 into valeriano-manassero:main Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants