Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
The current state of the product syncing via Feeds is broken - while plugin code base has business logic to generate feed file daily and serve the feed file on request, there is no logic for triggering a feed one time upload.
In this PR I am suggesting the following fixes to unblock product sync via feeds:
Trigger a daily feed upload sessions.
Update Feed file content by:
GTIN
to the feed filequantity_to_sell_on_facebook
to the feed fileDetailed test instructions:
A. Run new tests:
./vendor/bin/phpunit --filter ApiTest
./vendor/bin/phpunit --filter fbproductTest
B. Run all tests:
npm run test:php
Changelog entry
Fix - Fixed feeds by requesting a feed file upload session after feed file is generated and added missing new fields to the feed file.