Expose Bank class, Add Exposure specs #79
Conversation
Make Bank accesible
Add tests for all class accessibility
Make Bank accesible
Add missing parser
|
@vadymmarkov I had forgotten to expose the bank class so I fixed that. I also added tests for it so that other contributors don't forget to do it. I also made it backwards compatible so that the library can be run on Swift 3 and 4. |
dunyakirkali
changed the title
|
@dunyakirkali Great, but I wouldn't add Swift 3 backwards compatibility since we've already released Swift 4 version. |
|
@vadymmarkov Hmm, Could we then have a Swift 3 branch? I'm asking this since I have a project which I haven't updated yet to Swift 4. |
|
What do you think about merging it to master and then making Swift 3 branch? @dunyakirkali |
|
@vadymmarkov I think it would b better to first extract the swift3 stuff to a branch and merge the rest to master. I'll get back to you in a couple of days. |
dunyakirkali
changed the title
|
@vadymmarkov I updated the PR so that it only contains the exposure fix (and specs). The backwards compatibility changes are to be found here |
|
Awesome, thanks! |
No description provided.