Fix cursor position when initial value is set #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/index.js
Outdated
| @@ -34,7 +34,7 @@ class TextInput extends PureComponent { | |||
| }; | |||
|
|
|||
| state = { | |||
| cursorOffset: 0 | |||
| cursorOffset: this.props.value.length | |||
There was a problem hiding this comment.
Could you add a value: '' to defaultProps, so that it doesn't crash when this.props.value is missing?
There was a problem hiding this comment.
value is declared as required per the propTypes, setting a default value makes the linter complain.
I could change it so that it's not required, but I preferred to use a ternary operator to initialize cursorOffset.
Though, if you think it should be done differently, I'd be happy to change it.
There was a problem hiding this comment.
Good point. In that case I'd use (this.props.value || '').length instead.
There was a problem hiding this comment.
👍 updated!
thanks
vadimdemedes
changed the title
|
Great fix, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting an initial value, the cursor is still at the beginning of the line.
This PR sets the initial cursor offset to the value length, so the cursor is at the end of the input, ready to continue typing.