remove deprecated code #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmazak
force-pushed
the
deprecated
branch
8 times, most recently
from
a294c22 to
0788161
Compare
|
@janmazak I reviewed the PR, did a few minor changes and updated the Trezor tests and .raw files. Please check my changes and if you spot no issue, I believe this is good to go. |
Closed
janmazak
added a commit
that referenced
this pull request
Feb 7, 2023
* remove code related to internal hw-cli tx format * Remove extra exclamation marks * Remove old items from autocomplete.sh * Rename signing validation to witnessing validation * Add description to test/unit/commandParser/res/tx.raw * Update interop-lib * Change tx format in trezor tests * Change tx format in cli tx files * Add comments about manual test conversion Co-authored-by: David Misiak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unfinished