-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add preparation commit command pnpm adorno
#23
Conversation
7a2d305
to
d76b33f
Compare
pnpm prepare
pnpm adorno
- [ ] Ran `pnpm gas-report`? | ||
- [ ] Ran `pnpm lint`? | ||
- [ ] Ran `forge test`? | ||
- [ ] Ran `pnpm adorno`? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There could be an argument that removing forge test
here is not ideal, but on the other hand, this will then latest fail during CI when there's failing tests. So I think it's fine, but I still wanted to point it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forge test is implicit on forge snapshot and pnpm gas-report.
@3esmit FYI: if you still want to rename this commit message, you can still do it and then merge (or merge right away) |
I cant merge this, button is grayed out. |
@3esmit the reason it's grayed out is because your commits are signed. |
Also, tip for the future: We probably don't want to merge main into developing branches. That avoids us introducing these merge commits: e1f6eb1 |
e1f6eb1
to
3df4d72
Compare
@3esmit FYI: I've rebased your |
I don't mind, just want to understand the reason behind putting adorno as last command in package.json instead of how I left? |
@3esmit Ah, no particular reason. There was a merge conflict as there was the I just resolved the conflict without paying much attention to the order of the commands. |
Description
Fixes #19
Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge snapshot
?pnpm gas-report
?pnpm lint
?forge test
?pnpm verify
?