Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing type annotation for Ajv to Validator class #75

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Added missing type annotation for Ajv to Validator class #75

merged 1 commit into from
Feb 9, 2021

Conversation

NGTOne
Copy link
Contributor

@NGTOne NGTOne commented Feb 9, 2021

This resolves #67.

@simonplend simonplend added this to the Release v2.2.0 milestone Feb 9, 2021
@simonplend
Copy link
Collaborator

@NGTOne Amazing, thank you so much for fixing this! 🙏

@simonplend simonplend merged commit f055837 into vacekj:master Feb 9, 2021
@simonplend
Copy link
Collaborator

@NGTOne Have you by any chance run into the issue raised here: #39?

@NGTOne
Copy link
Contributor Author

NGTOne commented Feb 9, 2021

@NGTOne Have you by any chance run into the issue raised here: #39?

Repeatedly, in fact. I'll see if I can't take a gander at it this weekend.

@simonplend
Copy link
Collaborator

Repeatedly, in fact. I'll see if I can't take a gander at it this weekend.

@NGTOne That would be great, thank you! Fixing that problem is a bit beyond my TypeScript knowledge at the moment unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release v2.2.0
Development

Successfully merging this pull request may close these issues.

TypeScript definitions are missing a type for Validator#ajv
2 participants
@NGTOne @simonplend