Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Thailand holidays: refactor Royal Ploughing Ceremony code #2247

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

PPsyrius
Copy link
Collaborator

Proposed change

As แรกนาขวัญ (Royal Ploughing Ceremony) entries are all manually assigned, MAY, 13 fallback date is no longer needed.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (12f2602) to head (ef22e4d).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #2247   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          196       196           
  Lines        11891     11891           
  Branches      1717      1717           
=========================================
  Hits         11891     11891           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KJhellico KJhellico changed the title Update Thailand holidays: refractor Royal Ploughing Ceremony code Update Thailand holidays: refactor Royal Ploughing Ceremony code Jan 27, 2025
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@arkid15r arkid15r added this pull request to the merge queue Jan 27, 2025
Merged via the queue into vacanza:dev with commit f585cb5 Jan 27, 2025
32 checks passed
@PPsyrius PPsyrius deleted the th_raeknakhwan_refractor branch January 29, 2025 02:59
@arkid15r arkid15r mentioned this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants