Add Sri Lanka holidays

[Prateekshit73]

Proposed change

Added Sri Lanka holidays
Closes #1272

Type of change

• New country/market holidays support (thank you!)
• Supported country/market holidays update (calendar discrepancy fix, localization)
• Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
• Dependency update (version deprecation/pin/upgrade)
• Bugfix (non-breaking change which fixes an issue)
• Breaking change (a code change causing existing functionality to break)
• New feature (new holidays functionality in general)

Checklist

• I've followed the contributing guidelines
• I've successfully run make check, all checks and tests are green

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4526e2a) to head (8b034f6).
Report is 1 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##               dev     #2228    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          196       199     +3     
  Lines        11935     12134   +199     
  Branches      1722      1731     +9     
==========================================
+ Hits         11935     12134   +199     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[PPsyrius]

Nice to see new country being added 🚀

[PPsyrius]

I'm working up a solution for Poya Day calculations at the moment and will create a suggestion PR with them later - I was originally planned to base them on Thai LuniSolar calendar ones but it appears the results aren't a 100% match yet

[Prateekshit73]

I'm working up a solution for Poya Day calculations at the moment and will create a suggestion PR with them later - I was originally planned to base them on Thai LuniSolar calendar ones but it appears the results aren't a 100% match yet

If there's anything I can do to assist you with the Poya Day calculations, please let me know. I’d be more than happy to help out in any way I can!

[arkid15r]

@PPsyrius anything we should wait from you or this is good for review?

[PPsyrius]

@arkid15r no, many poya days assignments are still incorrect at the moment

[Prateekshit73]

Thanks for the update, @PPsyrius! If there's anything specific you'd like me to look into, just let me know. I'm happy to contribute!

[Prateekshit73]

For full coverage it's required to execute a branch where maha_sivarathri_date is None. But there is no such case in years range 2003-2025 (defined by start_year/end_year values for LK).

Hi Sir @KJhellico,

Thank you for your insights! Given that maha_sivarathri_date is never None for the years 2003-2025, do you think it would be feasible to change the start_year to a year before 2003? This could help us create a test case that triggers the branch where maha_sivarathri_date is None, allowing us to achieve full coverage.

As a referenced in the code itself, Sri Lanka's Holidays Act (No. 29 of 1971) was first proclaimed on September 2nd, 1971, which might provide context for setting the start_year.

[KJhellico]

`Sri Lanka's Holidays Act (No. 29 of 1971) was first proclaimed on September 2nd, 1971

Then I think it's better to pick 1972 as start_year.

[PPsyrius]

LGTM 🇱🇰

[KJhellico]

LGTM!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.0% Duplication on New Code

See analysis details on SonarQube Cloud

[arkid15r]

Thanks for this amazing contribution @Prateekshit73 !

LGTM

[Prateekshit73]

Thanks for this amazing contribution @Prateekshit73 !

I just initiated the PR; it was @PPsyrius, @KJhellico and you who made it work.

[arkid15r]

Thanks for this amazing contribution @Prateekshit73 !

I just initiated the PR; it was @PPsyrius, @KJhellico and you who made it work.

Yep, those two are just awesome in terms of calendars/holidays work. We are so lucky to have them as a part of the team.