Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce common.WorkingDayTests class #2207

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

KJhellico
Copy link
Collaborator

Proposed change

Introduce common.WorkingDaysTests class with working days testing methods.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a387595) to head (9e85855).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #2207   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          195       195           
  Lines        11762     11762           
  Branches      1699      1699           
=========================================
  Hits         11762     11762           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great refactoring, just some naming suggestions:

tests/common.py Outdated Show resolved Hide resolved
tests/common.py Outdated Show resolved Hide resolved
tests/common.py Outdated Show resolved Hide resolved
@KJhellico KJhellico force-pushed the add-working-days-test branch from d14ec12 to 9e85855 Compare January 2, 2025 19:52
@KJhellico KJhellico changed the title Introduce common.WorkingDaysTests class Introduce common.WorkingDayTests class Jan 2, 2025
Copy link

sonarqubecloud bot commented Jan 2, 2025

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkid15r arkid15r enabled auto-merge January 2, 2025 20:36
Copy link
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We can probably extend this test for remaining countries in the subsequent PRs as well i.e. Russia.

@arkid15r arkid15r added this pull request to the merge queue Jan 3, 2025
Merged via the queue into vacanza:dev with commit 16e6f17 Jan 3, 2025
32 checks passed
@KJhellico KJhellico deleted the add-working-days-test branch January 3, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants