-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce common.WorkingDayTests
class
#2207
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2207 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 195 195
Lines 11762 11762
Branches 1699 1699
=========================================
Hits 11762 11762 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great refactoring, just some naming suggestions:
d14ec12
to
9e85855
Compare
common.WorkingDaysTests
classcommon.WorkingDayTests
class
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We can probably extend this test for remaining countries in the subsequent PRs as well i.e. Russia.
Proposed change
Introduce
common.WorkingDaysTests
class with working days testing methods.Type of change
holidays
functionality in general)Checklist
make check
, all checks and tests are green