Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Norway holidays localization: th #2200

Merged
merged 8 commits into from
Jan 1, 2025
Merged

Add Norway holidays localization: th #2200

merged 8 commits into from
Jan 1, 2025

Conversation

ansntu
Copy link
Contributor

@ansntu ansntu commented Dec 31, 2024

Proposed change

  • Add Thai Translation for Norway Public Holidays.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (dc9877b) to head (47ba3c7).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #2200   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          195       195           
  Lines        11763     11762    -1     
  Branches      1700      1699    -1     
=========================================
- Hits         11763     11762    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PPsyrius PPsyrius changed the title add thai translation of norway holiday Add Norway holidays localization: th Dec 31, 2024
- update support language into one line code
- put support language and bracket into one line
Copy link
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see your first PR after the Australian th l10n ones as the Thai proof-reader :) @ansntu

holidays/countries/norway.py Outdated Show resolved Hide resolved
holidays/locale/th/LC_MESSAGES/NO.po Outdated Show resolved Hide resolved
ansntu and others added 2 commits December 31, 2024 18:31
Co-authored-by: Panpakorn Siripanich <[email protected]>
Signed-off-by: ansntu <[email protected]>
Co-authored-by: Panpakorn Siripanich <[email protected]>
Signed-off-by: ansntu <[email protected]>
PPsyrius
PPsyrius previously approved these changes Dec 31, 2024
Copy link
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🇳🇴

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
thanks for translating it @ansntu !

holidays/locale/th/LC_MESSAGES/NO.po Outdated Show resolved Hide resolved
Co-authored-by: Arkadii Yakovets <[email protected]>
Signed-off-by: ansntu <[email protected]>
- edit PO revision date
Copy link

sonarqubecloud bot commented Jan 1, 2025

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@arkid15r arkid15r enabled auto-merge January 1, 2025 02:19
@arkid15r arkid15r requested a review from KJhellico January 1, 2025 02:19
@arkid15r arkid15r added this pull request to the merge queue Jan 1, 2025
Merged via the queue into vacanza:dev with commit 1964c24 Jan 1, 2025
32 checks passed
@arkid15r arkid15r mentioned this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants